Skip to content

Conversation

Manavsaliya
Copy link

@Manavsaliya Manavsaliya commented Oct 7, 2025

Issue

The theme switcher didn’t update component appearances instantly when the theme changed. When using only appearance from useAppearance, components didn’t always receive the latest theme value from the hook.

Additionally, some components (like Stripe) don’t need the system theme value. For example, when i implementing a Stripe theme that matches the site’s light or dark mode colors, i had to manually handle system checks each time.

To simplify this, I introduced resolvedAppearance in the useAppearance hook, it always returns either light or dark, removing the need for extra logic.

Also cleaned up the useAppearance hook by removing duplicate code and making it more efficient.

Fix:

  • Theme switching: Components now update immediately when theme changes
  • QR codes: Now properly visible in dark mode

Also fixed for vue-starter-kit

Theme Switching Issue Demo

Screen.Recording.2025-10-07.222222.mp4

Before & After QR Code Visibility

Before After
qr-code-before qr-code-after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant